Skip to content

chore(docs): testing tutorials with playwright#6694

Closed
signorecello wants to merge 16 commits intomasterfrom
zpedro/tutorials_refactor
Closed

chore(docs): testing tutorials with playwright#6694
signorecello wants to merge 16 commits intomasterfrom
zpedro/tutorials_refactor

Conversation

@signorecello
Copy link
Contributor

@signorecello signorecello commented May 27, 2024

Draft of a devcontainer + tutorial (need the PR so I can try it with a real codespace)

Copy link
Contributor Author

signorecello commented May 27, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@signorecello signorecello marked this pull request as ready for review May 27, 2024 07:37
@signorecello signorecello marked this pull request as draft May 27, 2024 07:37
@signorecello signorecello force-pushed the zpedro/tutorials_refactor branch 5 times, most recently from cab854e to c564613 Compare June 2, 2024 17:18
@signorecello signorecello changed the base branch from master to zpedro/getting_started_reorder June 2, 2024 17:18
@AztecBot
Copy link
Collaborator

AztecBot commented Jun 2, 2024

Docs Preview

Hey there! 👋 You can check your preview at https://668d2995e0967c4bedbb9a72--aztec-docs-dev.netlify.app

@AztecBot
Copy link
Collaborator

AztecBot commented Jun 2, 2024

Benchmark results

Metrics with a significant change:

  • proof_construction_time_sha256_30_ms (32): 1,734 (+20%)
  • app_circuit_witness_generation_time_in_ms (ContractInstanceDeployer:deploy): 39.7 (+61%)
  • app_circuit_witness_generation_time_in_ms (MultiCallEntrypoint:entrypoint): 1,778 (+173%)
  • app_circuit_witness_generation_time_in_ms (GasToken:deploy): 983 (+78%)
  • app_circuit_witness_generation_time_in_ms (SchnorrAccount:constructor): 1,409 (+193%)
  • app_circuit_witness_generation_time_in_ms (SchnorrAccount:entrypoint): 2,813 (+239%)
  • app_circuit_witness_generation_time_in_ms (Token:privately_mint_private_note): 1,619 (+195%)
  • app_circuit_witness_generation_time_in_ms (FPC:fee_entrypoint_public): 353 (+253%)
  • app_circuit_witness_generation_time_in_ms (Token:transfer): 4,487 (+176%)
  • app_circuit_witness_generation_time_in_ms (Benchmarking:create_note): 1,393 (+193%)
  • app_circuit_witness_generation_time_in_ms (SchnorrAccount:verify_private_authwit): 77.9 (+90%)
  • app_circuit_witness_generation_time_in_ms (Token:unshield): 3,770 (+185%)
  • app_circuit_witness_generation_time_in_ms (FPC:fee_entrypoint_private): 4,935 (+187%)
  • protocol_circuit_simulation_time_in_ms (private-kernel-inner): 391 (+76%)
  • protocol_circuit_simulation_time_in_ms (private-kernel-tail): 370 (-65%)
  • protocol_circuit_simulation_time_in_ms (root-parity): 48.7 (-30%)
  • protocol_circuit_simulation_time_in_ms (base-rollup): 7,866 (+88%)
  • protocol_circuit_simulation_time_in_ms (public-kernel-setup): 712 (+279%)
  • protocol_circuit_simulation_time_in_ms (public-kernel-app-logic): 608 (+319%)
  • protocol_circuit_simulation_time_in_ms (public-kernel-tail): 1,402 (+57%)
  • protocol_circuit_simulation_time_in_ms (private-kernel-reset-small): 591 (+102%)
  • protocol_circuit_simulation_time_in_ms (public-kernel-teardown): 610 (+359%)
  • protocol_circuit_input_size_in_bytes (private-kernel-inner): 94,902 (+16%)
  • protocol_circuit_input_size_in_bytes (private-kernel-tail): 99,121 (+59%)
  • protocol_circuit_input_size_in_bytes (base-parity): 128 (-20%)
  • protocol_circuit_input_size_in_bytes (public-kernel-tail): 511,910 (+28%)
  • protocol_circuit_input_size_in_bytes (private-kernel-reset-small): 123,313 (+56%)
  • protocol_circuit_output_size_in_bytes (private-kernel-init): 67,190 (+22%)
  • protocol_circuit_output_size_in_bytes (private-kernel-inner): 67,190 (+22%)
  • protocol_circuit_output_size_in_bytes (private-kernel-tail): 71,733 (+16%)
  • protocol_circuit_output_size_in_bytes (base-parity): 64.0 (-33%)
  • protocol_circuit_output_size_in_bytes (root-parity): 64.0 (-33%)
  • protocol_circuit_output_size_in_bytes (base-rollup): 756 (+20%)
  • protocol_circuit_output_size_in_bytes (public-kernel-setup): 93,334 (+16%)
  • protocol_circuit_output_size_in_bytes (public-kernel-app-logic): 93,334 (+16%)
  • protocol_circuit_output_size_in_bytes (private-kernel-reset-small): 67,190 (+22%)
  • protocol_circuit_output_size_in_bytes (public-kernel-teardown): 93,334 (+16%)
  • protocol_circuit_output_size_in_bytes (merge-rollup): 756 (+20%)
  • tx_size_in_bytes (0): 85,672 (+16%)
  • avm_simulation_time_ms (Token:mint_public): 65.9 (-81%)
  • avm_simulation_time_ms (Token:assert_minter_and_mint): 242 (+510%)
  • avm_simulation_time_ms (FPC:prepare_fee): 186 (+86%)
  • avm_simulation_time_ms (Token:transfer_public): 52.1 (+43%)
  • avm_simulation_time_ms (Benchmarking:increment_balance): 2,670 (+102%)
  • avm_simulation_bytecode_size_in_bytes (FPC:pay_refund): 20,080 (-21%)
  • avm_simulation_bytecode_size_in_bytes (FPC:pay_refund_with_shielded_rebate): 21,167 (-20%)
  • app_circuit_proving_time_in_ms (SchnorrAccount:entrypoint): 55,424 (+1062%)
  • app_circuit_proving_time_in_ms (FPC:fee_entrypoint_public): 11,085 (+547%)
  • app_circuit_proving_time_in_ms (Token:transfer): 46,656 (+300%)
  • app_circuit_proving_time_in_ms (FPC:prepare_fee (avm)): 5,821 (+113%)
  • app_circuit_proving_time_in_ms (Token:transfer_public (avm)): 3,005 (-21%)
  • app_circuit_proving_time_in_ms (FPC:pay_refund (avm)): 11,083 (-54%)
  • app_circuit_size_in_gates (SchnorrAccount:entrypoint): 2,097,152 (+1500%)
  • app_circuit_size_in_gates (FPC:fee_entrypoint_public): 524,288 (+700%)
  • app_circuit_size_in_gates (Token:transfer): 2,097,152 (+300%)
  • protocol_circuit_witness_generation_time_in_ms (private-kernel-init): 469 (+18%)
  • protocol_circuit_witness_generation_time_in_ms (private-kernel-inner): 1,114 (+56%)
  • protocol_circuit_witness_generation_time_in_ms (private-kernel-reset-small): 1,929 (+50%)
  • protocol_circuit_witness_generation_time_in_ms (private-kernel-tail-to-public): 6,810 (-35%)
  • protocol_circuit_witness_generation_time_in_ms (private-kernel-tail): 1,801 (-27%)
  • protocol_circuit_witness_generation_time_in_ms (base-parity): 1,899 (+107%)
  • protocol_circuit_witness_generation_time_in_ms (public-kernel-setup): 3,700 (+53%)
  • protocol_circuit_witness_generation_time_in_ms (public-kernel-app-logic): 4,696 (+40%)
  • protocol_circuit_witness_generation_time_in_ms (public-kernel-teardown): 4,676 (+38%)
  • protocol_circuit_witness_generation_time_in_ms (public-kernel-tail): 38,865 (+41%)
  • protocol_circuit_proving_time_in_ms (private-kernel-inner): 48,829 (+70%)
  • protocol_circuit_proving_time_in_ms (private-kernel-reset-small): 45,183 (+66%)
  • protocol_circuit_proving_time_in_ms (private-kernel-tail-to-public): 99,972 (+70%)
  • protocol_circuit_proof_size_in_bytes (private-kernel-init): 92,352 (+24%)
  • protocol_circuit_proof_size_in_bytes (private-kernel-inner): 92,352 (+24%)
  • protocol_circuit_proof_size_in_bytes (private-kernel-reset-small): 92,352 (+24%)
  • protocol_circuit_proof_size_in_bytes (private-kernel-tail-to-public): 125,344 (+17%)
  • protocol_circuit_proof_size_in_bytes (public-kernel-setup): 125,344 (+17%)
  • protocol_circuit_proof_size_in_bytes (public-kernel-app-logic): 125,344 (+17%)
  • protocol_circuit_proof_size_in_bytes (public-kernel-teardown): 125,344 (+17%)
  • protocol_circuit_size_in_gates (private-kernel-inner): 2,097,152 (+100%)
  • protocol_circuit_size_in_gates (private-kernel-reset-small): 2,097,152 (+100%)
  • protocol_circuit_size_in_gates (private-kernel-tail-to-public): 4,194,304 (+100%)
  • protocol_circuit_num_public_inputs (private-kernel-init): 2,819 (+25%)
  • protocol_circuit_num_public_inputs (private-kernel-inner): 2,819 (+25%)
  • protocol_circuit_num_public_inputs (private-kernel-reset-small): 2,819 (+25%)
  • protocol_circuit_num_public_inputs (private-kernel-tail-to-public): 3,850 (+18%)
  • protocol_circuit_num_public_inputs (base-parity): 2.00 (-33%)
  • protocol_circuit_num_public_inputs (public-kernel-setup): 3,850 (+18%)
  • protocol_circuit_num_public_inputs (public-kernel-app-logic): 3,850 (+18%)
  • protocol_circuit_num_public_inputs (public-kernel-teardown): 3,850 (+18%)
  • l2_block_building_time_in_ms (4): 25,482 (+97%)
  • l2_block_building_time_in_ms (8): 50,338 (+96%)
  • l2_block_building_time_in_ms (16): 99,951 (+100%)
  • l2_block_rollup_simulation_time_in_ms (4): 25,482 (+97%)
  • l2_block_rollup_simulation_time_in_ms (8): 50,337 (+96%)
  • l2_block_rollup_simulation_time_in_ms (16): 99,950 (+100%)
  • l2_block_public_tx_process_time_in_ms (4): 21,905 (+101%)
  • l2_block_public_tx_process_time_in_ms (8): 46,587 (+99%)
  • l2_block_public_tx_process_time_in_ms (16): 96,225 (+101%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric 1 threads 4 threads 16 threads 32 threads 64 threads
proof_construction_time_sha256_30_ms 11,727 (-1%) 3,142 (-2%) 1,437 (+2%) ⚠️ 1,734 (+20%) 1,533 (+5%)
proof_construction_time_sha256_100_ms 43,881 (-1%) 11,751 (-2%) 5,461 5,392 5,377
proof_construction_time_poseidon_hash_ms 78.0 34.0 34.0 56.0 (-5%) 88.0
proof_construction_time_poseidon_hash_30_ms 1,519 (-1%) 419 200 (-1%) 223 263 (-1%)
proof_construction_time_poseidon_hash_100_ms 5,748 (+1%) 1,579 (+3%) 731 (+8%) 770 (+5%) 802 (+7%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 4 txs 8 txs 16 txs
l1_rollup_calldata_size_in_bytes 1,412 1,412 1,412
l1_rollup_calldata_gas 9,476 9,464 9,452
l1_rollup_execution_gas 610,297 (-1%) 610,285 (-1%) 610,273 (-1%)
l2_block_processing_time_in_ms 763 (+1%) 1,423 2,699
l2_block_building_time_in_ms ⚠️ 25,482 (+97%) ⚠️ 50,338 (+96%) ⚠️ 99,951 (+100%)
l2_block_rollup_simulation_time_in_ms ⚠️ 25,482 (+97%) ⚠️ 50,337 (+96%) ⚠️ 99,950 (+100%)
l2_block_public_tx_process_time_in_ms ⚠️ 21,905 (+101%) ⚠️ 46,587 (+99%) ⚠️ 96,225 (+101%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric 3 blocks 5 blocks
node_history_sync_time_in_ms 7,098 (+1%) 9,935
node_database_size_in_bytes 12,161,104 (-2%) 16,097,360
pxe_database_size_in_bytes 16,254 26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit simulation_time_in_ms witness_generation_time_in_ms proving_time_in_ms input_size_in_bytes output_size_in_bytes proof_size_in_bytes num_public_inputs size_in_gates
private-kernel-init 133 (+22%) ⚠️ 469 (+18%) 12,826 (-13%) 20,634 (+3%) ⚠️ 67,190 (+22%) ⚠️ 92,352 (+24%) ⚠️ 2,819 (+25%) 524,288
private-kernel-inner ⚠️ 391 (+76%) ⚠️ 1,114 (+56%) ⚠️ 48,829 (+70%) ⚠️ 94,902 (+16%) ⚠️ 67,190 (+22%) ⚠️ 92,352 (+24%) ⚠️ 2,819 (+25%) ⚠️ 2,097,152 (+100%)
private-kernel-tail ⚠️ 370 (-65%) ⚠️ 1,801 (-27%) 53,246 (-1%) ⚠️ 99,121 (+59%) ⚠️ 71,733 (+16%) 14,912 399 2,097,152
base-parity 6.16 (-2%) ⚠️ 1,899 (+107%) 2,728 (+3%) ⚠️ 128 (-20%) ⚠️ 64.0 (-33%) 2,208 (-1%) ⚠️ 2.00 (-33%) 131,072
root-parity ⚠️ 48.7 (-30%) 76.3 (+10%) 39,012 (-5%) 27,100 (-3%) ⚠️ 64.0 (-33%) 2,720 (-1%) 18.0 (-5%) 2,097,152
base-rollup ⚠️ 7,866 (+88%) 4,901 (-1%) 86,812 (-9%) 170,330 (-1%) ⚠️ 756 (+20%) 3,648 (+3%) 47.0 (+7%) 4,194,304
root-rollup 110 (-13%) 87.4 (+5%) 21,866 (-11%) 25,309 (+1%) 620 (-5%) 3,456 (-1%) 41.0 (-2%) 1,048,576
public-kernel-setup ⚠️ 712 (+279%) ⚠️ 3,700 (+53%) 45,192 (+3%) 116,905 (+13%) ⚠️ 93,334 (+16%) ⚠️ 125,344 (+17%) ⚠️ 3,850 (+18%) 2,097,152
public-kernel-app-logic ⚠️ 608 (+319%) ⚠️ 4,696 (+40%) 45,690 (+2%) 116,905 (+13%) ⚠️ 93,334 (+16%) ⚠️ 125,344 (+17%) ⚠️ 3,850 (+18%) 2,097,152
public-kernel-tail ⚠️ 1,402 (+57%) ⚠️ 38,865 (+41%) 186,221 (+1%) ⚠️ 511,910 (+28%) 10,014 14,912 399 8,388,608
private-kernel-reset-small ⚠️ 591 (+102%) ⚠️ 1,929 (+50%) ⚠️ 45,183 (+66%) ⚠️ 123,313 (+56%) ⚠️ 67,190 (+22%) ⚠️ 92,352 (+24%) ⚠️ 2,819 (+25%) ⚠️ 2,097,152 (+100%)
public-kernel-teardown ⚠️ 610 (+359%) ⚠️ 4,676 (+38%) 46,894 (+7%) 116,905 (+13%) ⚠️ 93,334 (+16%) ⚠️ 125,344 (+17%) ⚠️ 3,850 (+18%) 2,097,152
merge-rollup 28.8 (-29%) N/A N/A 16,542 (+3%) ⚠️ 756 (+20%) N/A N/A N/A
private-kernel-tail-to-public N/A ⚠️ 6,810 (-35%) ⚠️ 99,972 (+70%) N/A N/A ⚠️ 125,344 (+17%) ⚠️ 3,850 (+18%) ⚠️ 4,194,304 (+100%)

Stats on running time collected for app circuits

Function input_size_in_bytes output_size_in_bytes witness_generation_time_in_ms proof_size_in_bytes proving_time_in_ms size_in_gates num_public_inputs
ContractClassRegisterer:register 1,344 (+2%) 9,944 (+6%) 422 (+6%) N/A N/A N/A N/A
ContractInstanceDeployer:deploy 1,408 (+2%) 9,944 (+6%) ⚠️ 39.7 (+61%) N/A N/A N/A N/A
MultiCallEntrypoint:entrypoint 1,920 (+2%) 9,944 (+6%) ⚠️ 1,778 (+173%) N/A N/A N/A N/A
GasToken:deploy 1,376 (+2%) 9,944 (+6%) ⚠️ 983 (+78%) N/A N/A N/A N/A
SchnorrAccount:constructor 1,312 (+3%) 9,944 (+6%) ⚠️ 1,409 (+193%) N/A N/A N/A N/A
SchnorrAccount:entrypoint 2,304 (+1%) 9,944 (+6%) ⚠️ 2,813 (+239%) 16,768 (+6%) ⚠️ 55,424 (+1062%) ⚠️ 2,097,152 (+1500%) 457 (+7%)
Token:privately_mint_private_note 1,280 (+3%) 9,944 (+6%) ⚠️ 1,619 (+195%) N/A N/A N/A N/A
FPC:fee_entrypoint_public 1,344 (+2%) 9,944 (+6%) ⚠️ 353 (+253%) 16,768 (+6%) ⚠️ 11,085 (+547%) ⚠️ 524,288 (+700%) 457 (+7%)
Token:transfer 1,312 (+3%) 9,944 (+6%) ⚠️ 4,487 (+176%) 16,768 (+6%) ⚠️ 46,656 (+300%) ⚠️ 2,097,152 (+300%) 457 (+7%)
AuthRegistry:set_authorized (avm) 21,043 (+9%) N/A N/A 87,200 (-4%) 1,335 (+4%) N/A N/A
FPC:prepare_fee (avm) 28,521 (+7%) N/A N/A 88,032 (-4%) ⚠️ 5,821 (+113%) N/A N/A
AuthRegistry:consume (avm) 34,973 (+6%) N/A N/A 87,616 (-4%) 2,966 (+8%) N/A N/A
Token:transfer_public (avm) 44,849 (+5%) N/A N/A 87,616 (-4%) ⚠️ 3,005 (-21%) N/A N/A
FPC:pay_refund (avm) 33,381 (-9%) N/A N/A 88,448 (-3%) ⚠️ 11,083 (-54%) N/A N/A
Benchmarking:create_note 1,344 (+2%) 9,944 (+6%) ⚠️ 1,393 (+193%) N/A N/A N/A N/A
SchnorrAccount:verify_private_authwit 1,280 (+3%) 9,944 (+6%) ⚠️ 77.9 (+90%) N/A N/A N/A N/A
Token:unshield 1,376 (+2%) 9,944 (+6%) ⚠️ 3,770 (+185%) N/A N/A N/A N/A
FPC:fee_entrypoint_private 1,376 (+2%) 9,944 (+6%) ⚠️ 4,935 (+187%) N/A N/A N/A N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function time_ms bytecode_size_in_bytes
GasToken:_increase_public_balance 66.8 (-16%) 13,873 (+1%)
GasToken:set_portal 17.9 (+5%) 3,495 (+5%)
Token:constructor 95.2 (-8%) 24,207 (+2%)
FPC:constructor 62.7 (-16%) 13,893 (+2%)
GasToken:mint_public 51.6 (-18%) 10,241 (+1%)
Token:mint_public ⚠️ 65.9 (-81%) 19,216 (+1%)
Token:assert_minter_and_mint ⚠️ 242 (+510%) 13,034 (+1%)
AuthRegistry:set_authorized 31.1 (-8%) 7,869 (+1%)
FPC:prepare_fee ⚠️ 186 (+86%) 15,187 (+1%)
Token:transfer_public ⚠️ 52.1 (+43%) 31,425 (+1%)
FPC:pay_refund 123 (-7%) ⚠️ 20,080 (-21%)
Benchmarking:increment_balance ⚠️ 2,670 (+102%) 15,465 (+1%)
Token:_increase_public_balance 56.5 (-10%) 15,089 (+1%)
FPC:pay_refund_with_shielded_rebate 146 (+29%) ⚠️ 21,167 (-20%)

Public DB Access

Time to access various public DBs.

Function time_ms
get-nullifier-index 0.158 (+1%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 256 leaves 512 leaves 1024 leaves
batch_insert_into_append_only_tree_16_depth_ms 10.4 (+1%) 16.8 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.8 31.7 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.601 0.515 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 48.3 76.0 131 246 (-1%) 471
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 95.9 159 287 543 1,055
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.493 0.467 (-1%) 0.450 0.446 (-1%) 0.439
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 59.6 112 (+1%) 182 355 693
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 109 207 355 691 1,363
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.503 0.500 0.483 0.481 0.475
batch_insert_into_indexed_tree_40_depth_ms N/A N/A 73.0 N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A 133 N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A 0.519 N/A N/A N/A N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes ⚠️ 85,672 (+16%) 670,983

Transaction size based on fee payment method

| Metric | |
| - | |

@signorecello signorecello changed the base branch from zpedro/getting_started_reorder to master June 5, 2024 12:36
@signorecello signorecello force-pushed the zpedro/tutorials_refactor branch from 7ec0d97 to 0587d6c Compare June 20, 2024 19:37
@signorecello signorecello marked this pull request as ready for review June 20, 2024 19:39
@signorecello signorecello changed the title first push (needed for devcontainer) chore(docs): testing tutorials with playwright Jun 20, 2024
@signorecello signorecello force-pushed the zpedro/tutorials_refactor branch 14 times, most recently from d600d23 to a0d2fe7 Compare June 25, 2024 20:27
@signorecello signorecello force-pushed the zpedro/tutorials_refactor branch 6 times, most recently from cd225b1 to 0280dbe Compare June 26, 2024 12:03
@signorecello signorecello force-pushed the zpedro/tutorials_refactor branch 2 times, most recently from 5d34ba5 to 21459c1 Compare June 26, 2024 13:24
@signorecello signorecello force-pushed the zpedro/tutorials_refactor branch from 21459c1 to 0523404 Compare June 26, 2024 15:19
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024

Changes to circuit sizes

Generated at commit: 337df68b9d413a951a2637fbd4a1981a25505be6, compared to commit: 6b2a351910f4e95ade690157de0574cb9a10b4e3

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_reset +109,734 ❌ +82.93% +850,398 ❌ +50.19%
public_kernel_app_logic +99,437 ❌ +41.25% +642,493 ❌ +46.43%
public_kernel_teardown +99,439 ❌ +41.21% +642,493 ❌ +46.43%
private_kernel_reset_big +86,523 ❌ +93.69% +503,483 ❌ +41.98%
public_kernel_setup +98,211 ❌ +53.74% +482,687 ❌ +36.57%
private_kernel_reset_medium +74,920 ❌ +103.54% +330,028 ❌ +34.67%
private_kernel_reset_small +69,118 ❌ +110.83% +243,260 ❌ +29.37%
private_kernel_tail_to_public +14,702 ❌ +3.31% +439,349 ❌ +26.17%
private_kernel_init_simulated 0 ➖ 0.00% +567 ❌ +25.30%
private_kernel_inner_simulated 0 ➖ 0.00% +567 ❌ +25.30%
private_kernel_reset_simulated 0 ➖ 0.00% +567 ❌ +25.30%
private_kernel_reset_simulated_big 0 ➖ 0.00% +567 ❌ +25.30%
private_kernel_reset_simulated_medium 0 ➖ 0.00% +567 ❌ +25.30%
private_kernel_reset_simulated_small 0 ➖ 0.00% +567 ❌ +25.30%
private_kernel_inner +9,040 ❌ +20.33% +248,050 ❌ +23.75%
public_kernel_tail +245,750 ❌ +25.31% +1,018,644 ❌ +23.11%
private_kernel_tail_to_public_simulated 0 ➖ 0.00% +575 ❌ +17.62%
public_kernel_app_logic_simulated 0 ➖ 0.00% +575 ❌ +17.62%
public_kernel_setup_simulated 0 ➖ 0.00% +575 ❌ +17.62%
public_kernel_teardown_simulated 0 ➖ 0.00% +575 ❌ +17.62%
rollup_base_simulated 0 ➖ 0.00% +3 ❌ +9.09%
private_kernel_tail +578 ❌ +2.70% +90,830 ❌ +7.29%
private_kernel_init +4,995 ❌ +19.44% +10,949 ❌ +2.88%
rollup_base -166 ✅ -0.05% +31,713 ❌ +1.03%
parity_base -1 ✅ -0.29% 0 ➖ 0.00%
private_kernel_empty -1 ✅ -0.11% -2 ✅ -0.00%
rollup_merge -114 ✅ -7.98% -1,053 ✅ -0.17%
rollup_root -123 ✅ -5.42% -1,950 ✅ -0.21%
private_kernel_empty_simulated 0 ➖ 0.00% -1 ✅ -0.26%
private_kernel_tail_simulated 0 ➖ 0.00% -1 ✅ -0.26%
public_kernel_tail_simulated 0 ➖ 0.00% -1 ✅ -0.26%
parity_root -43 ✅ -1.97% -3,582 ✅ -0.32%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_reset 242,060 (+109,734) +82.93% 2,544,643 (+850,398) +50.19%
public_kernel_app_logic 340,522 (+99,437) +41.25% 2,026,182 (+642,493) +46.43%
public_kernel_teardown 340,720 (+99,439) +41.21% 2,026,421 (+642,493) +46.43%
private_kernel_reset_big 178,873 (+86,523) +93.69% 1,702,904 (+503,483) +41.98%
public_kernel_setup 280,960 (+98,211) +53.74% 1,802,698 (+482,687) +36.57%
private_kernel_reset_medium 147,281 (+74,920) +103.54% 1,282,036 (+330,028) +34.67%
private_kernel_reset_small 131,484 (+69,118) +110.83% 1,071,601 (+243,260) +29.37%
private_kernel_tail_to_public 458,567 (+14,702) +3.31% 2,118,159 (+439,349) +26.17%
private_kernel_init_simulated 1 (0) 0.00% 2,808 (+567) +25.30%
private_kernel_inner_simulated 1 (0) 0.00% 2,808 (+567) +25.30%
private_kernel_reset_simulated 1 (0) 0.00% 2,808 (+567) +25.30%
private_kernel_reset_simulated_big 1 (0) 0.00% 2,808 (+567) +25.30%
private_kernel_reset_simulated_medium 1 (0) 0.00% 2,808 (+567) +25.30%
private_kernel_reset_simulated_small 1 (0) 0.00% 2,808 (+567) +25.30%
private_kernel_inner 53,511 (+9,040) +20.33% 1,292,649 (+248,050) +23.75%
public_kernel_tail 1,216,847 (+245,750) +25.31% 5,427,095 (+1,018,644) +23.11%
private_kernel_tail_to_public_simulated 1 (0) 0.00% 3,839 (+575) +17.62%
public_kernel_app_logic_simulated 1 (0) 0.00% 3,839 (+575) +17.62%
public_kernel_setup_simulated 1 (0) 0.00% 3,839 (+575) +17.62%
public_kernel_teardown_simulated 1 (0) 0.00% 3,839 (+575) +17.62%
rollup_base_simulated 1 (0) 0.00% 36 (+3) +9.09%
private_kernel_tail 21,972 (+578) +2.70% 1,336,812 (+90,830) +7.29%
private_kernel_init 30,687 (+4,995) +19.44% 390,776 (+10,949) +2.88%
rollup_base 339,099 (-166) -0.05% 3,096,787 (+31,713) +1.03%
parity_base 346 (-1) -0.29% 79,811 (0) 0.00%
private_kernel_empty 922 (-1) -0.11% 271,654 (-2) -0.00%
rollup_merge 1,315 (-114) -7.98% 601,662 (-1,053) -0.17%
rollup_root 2,145 (-123) -5.42% 910,781 (-1,950) -0.21%
private_kernel_empty_simulated 1 (0) 0.00% 388 (-1) -0.26%
private_kernel_tail_simulated 1 (0) 0.00% 388 (-1) -0.26%
public_kernel_tail_simulated 1 (0) 0.00% 388 (-1) -0.26%
parity_root 2,139 (-43) -1.97% 1,129,295 (-3,582) -0.32%

@ludamad ludamad requested a review from charlielye as a code owner March 6, 2025 22:02
@charlielye
Copy link
Contributor

Ancient. Never got landed. Rework and reopen if still relevant.

@charlielye charlielye closed this Mar 13, 2025
@ludamad ludamad deleted the zpedro/tutorials_refactor branch December 3, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants